Fix rewatch compilation of file starting with a lowercase letter #7700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsnobip
force-pushed
the
rewatch-file-casing-2
branch
3 times, most recently
from
03cebc3 to
479ac7c
Compare
|
@tsnobip I don’t believe there’s an issue here. The error seems to be a bit misleading; I was able to successfully build the sample project. Since it’s now configured correctly, the number of files in the shell tests needs to be updated accordingly. |
|
Okay, I take that back. It was working for me after those file count tweaks on Mac. |
tsnobip
changed the title
tsnobip
force-pushed
the
rewatch-file-casing-2
branch
3 times, most recently
from
3b4a526 to
efdbe42
Compare
tsnobip
commented
Jul 30, 2025
Comment on lines
+581
to
+582
| let basename = | ||
| helpers::file_path_to_compiler_asset_basename(implementation_file_path, &package.namespace); |
This reverts commit 2da1956.
tsnobip
force-pushed
the
rewatch-file-casing-2
branch
from
fa765ac to
0615cc3
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7569 added the test-repo but the test was not being run.