Support completions and better hovers for first class modules #7780
+319
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… extension module types)
There was a problem hiding this comment.
Pull Request Overview
This PR improves ReScript language server support for first class modules by enabling completions and enhanced hover functionality. The changes ensure that first-class modules can be properly unpacked, have their signatures displayed in hovers, and provide appropriate completions for their members.
Key changes:
- Added hover support to display module type signatures for first-class modules
- Implemented completion support for accessing members of unpacked first-class modules
- Enhanced pattern matching to properly register unpacked first-class modules in the analysis pipeline
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/analysis_tests/tests/src/FirstClassModules.res | Test file demonstrating first-class module hover and completion scenarios |
| tests/analysis_tests/tests/src/expected/FirstClassModules.res.txt | Expected test output showing hover info and completion results |
| analysis/src/StructureUtils.ml | New utility for filtering duplicate items from module structures |
| analysis/src/ProcessExtra.ml | Enhanced pattern processing to detect and register first-class module unpacks |
| analysis/src/ProcessCmt.ml | Updated structure item processing to handle first-class module unpack patterns |
| analysis/src/Hover.ml | Added support for displaying module type signatures when hovering over first-class modules |
| analysis/src/CompletionFrontEnd.ml | Fixed scope handling for unpacked module patterns |
| analysis/src/CompletionBackEnd.ml | Enhanced completion logic to support first-class module member access |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the situation around first class modules, support completions for them, and enhancing hovers.
Ended up a bit more involved than I had hoped, but I think it worked out well in the end.