Fix result examples #7914
Merged
Fix result examples #7914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhammerschmidt
commented
Sep 20, 2025
tests/docstring_tests/DocTest.res
Outdated
| // Let's add the examples inside a Test module because some examples | ||
| // have type definitions that are not supported inside a block. | ||
| // Also add unit type `()` | ||
| // Also add unit type `()`. Also wrap in async to make top-level awaits work. |
There was a problem hiding this comment.
This might be controversial, but all tests pass.
There was a problem hiding this comment.
I assume there is no noticeable performance difference from this?
There was a problem hiding this comment.
Nope:
master
node scripts/test.js -docstrings 8.49s user 2.25s system 365% cpu 2.938 totalfix-result-examples
node scripts/test.js -docstrings 8.44s user 2.04s system 357% cpu 2.933 total
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
fhammerschmidt
force-pushed
the
fix-result-examples
branch
from
1fa0790 to
8f904fd
Compare
cknitt
approved these changes
Sep 21, 2025
tests/docstring_tests/DocTest.res
Outdated
| // Let's add the examples inside a Test module because some examples | ||
| // have type definitions that are not supported inside a block. | ||
| // Also add unit type `()` | ||
| // Also add unit type `()`. Also wrap in async to make top-level awaits work. |
There was a problem hiding this comment.
I assume there is no noticeable performance difference from this?
|
I'm fine with this as-is, can't imagine the perf overhead would be something we need to care about. But if we wanted to care, a quick optimization could be to only wrap if the generated JS text contains |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vibecoded examples of course, sorry!