Casing namespace #145
Merged
Casing namespace #145
+105
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsnobip
reviewed
Nov 29, 2024
| @@ -312,7 +333,7 @@ impl Config { | |||
| namespace if namespace.is_case(Case::UpperFlat) => { | |||
| packages::Namespace::Namespace(namespace.to_string()) | |||
| } | |||
| namespace => packages::Namespace::Namespace(namespace.to_string().to_case(Case::Pascal)), | |||
| namespace => packages::Namespace::Namespace(namespace_from_package_name(namespace)), | |||
There was a problem hiding this comment.
There is another use of to_case(Case::Pascal) on line 348, but actually I think you can simplify this match quite a lot and always process namespace whatever the initial case with this new function.
|
This is amazing, can we merge this? |
|
Can't fix CI this week. Feel free to tweak this if you have the bandwidth. |
jfrolich
approved these changes
May 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #144
I have very little idea what I'm doing here.
I don't know any Rust and just tried the hint of @tsnobip in #144 (comment)