feat(react-email): Unify all components into react-email
#1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 7893566 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gabrielmfern
added
Package: react-email
gabrielmfern
force-pushed
the
feat/unify-packages
branch
from
02eb228 to
ff43b73
Compare
gabrielmfern
force-pushed
the
canary
branch
2 times, most recently
from
4ee4d1d to
0187b0a
Compare
gabrielmfern
force-pushed
the
feat/unify-packages
branch
3 times, most recently
from
46eb766 to
946127b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…-email/components also make the error message smaller
gabrielmfern
force-pushed
the
4.0
branch
3 times, most recently
from
c6cba17 to
63e2bf6
Compare
gabrielmfern
force-pushed
the
4.0
branch
4 times, most recently
from
d80b04b to
92ff716
Compare
gabrielmfern
force-pushed
the
4.0
branch
3 times, most recently
from
5aafe32 to
db0ec80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all components into
packages/react-email/src/packageon each individual folder and builds them all together so that users can import fromreact-emailinstead of from@react-email/components.To actually get this to work in a simple way, I changed Tailwind to be built with tsup instead of with vite, this makes things a bit simpler and also makes it safer for edge cases. The only way I got this to work properly was through patching the dependencies that had some problem, this also came with the trade-off caused by the fact that pnpm doesn't let you patch a version of the package while using another unpatched version of it. To properly deal with this, the only way I found was to keep a patched version of the packages in the workspace and use them on the Tailwind component, this is the reason for the 400 Files changed.
I also added in a simple optimization to the
getEmailComponentfunction so that it uses the rebuild API for faster builds.Another change I made was to upgrade the tests under
tailwind/integrations/*so that they are a bit simpler and safer.This PR also does small changes to turbo and the Github Action to avoid duplicated work being done.
The reason for the amount of additions being so large in comparison to the deletions is both because of the new
patched/*directory and also because I have not removed all the component packages frompackages/*as it's probably better to remove it on another subsequent PR.