fix: Types #296
Merged
fix: Types #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukinoshita
commented
Jan 16, 2024
Comment on lines
+6
to
+10
| audienceId: string; | ||
| email: string; | ||
| unsubscribed?: boolean; | ||
| first_name?: string; | ||
| last_name?: string; | ||
| firstName?: string; | ||
| lastName?: string; |
There was a problem hiding this comment.
These are breaking changes
vcapretz
reviewed
Jan 16, 2024
| payload, | ||
| `/audiences/${payload.audienceId}/contacts/${payload.id}`, | ||
| { | ||
| ...payload, |
There was a problem hiding this comment.
should we destruct audienceId in here? I don't think it's used in the API's body, but the way we have now will send extra keys in the body.
an even better option would be to explicitly send what we want (since we only care about 3 keys)
Suggested change
| ...payload, | |
| unsubscribed: payload.unsubscribed, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.