Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes OAuth1 signature with special characters (#2126, #1945) #2127

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

elia936
Copy link
Contributor

@elia936 elia936 commented Aug 16, 2023

Description

Fixes OAuth1 signature which is generated wrong when containing special characters
#2126 , #1945

Purpose

This pull request is a:

  • [ x] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@elia936
Copy link
Contributor Author

elia936 commented Aug 17, 2023 via email

@alexeyzimarev
Copy link
Member

Thank you for the PR. It would be great if you can add a test that would reproduce the issue, and turns green after the fix.

@teunlielu
Copy link

Example code can you found on bug: #2126

@teunlielu
Copy link

@alexeyzimarev wat need we more to merge code?
I see test code is add.

@alexeyzimarev alexeyzimarev merged commit 122a2b0 into restsharp:dev Feb 7, 2024
1 check passed
@alexeyzimarev
Copy link
Member

@teunlielu done! sorry about the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants