Skip to content

fix type filter for custom fields #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Neur0toxine merged 1 commit into from
Jan 19, 2026
Merged

fix type filter for custom fields #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7398,10 +7398,21 @@ func TestClient_CustomFields(t *testing.T) {

gock.New(crmURL).
Get("/custom-fields").
AddMatcher(func(r *http.Request, _ *gock.Request) (bool, error) {
typeValues, ok := r.URL.Query()["filter[type][]"]
if !ok || len(typeValues) != 2 {
return false, nil
}
return typeValues[0] == "string" && typeValues[1] == "text", nil
}).
Reply(200).
BodyString(`{"success": true}`)

data, status, err := c.CustomFields(CustomFieldsRequest{})
data, status, err := c.CustomFields(CustomFieldsRequest{
Filter: CustomFieldsFilter{
Type: []string{"string", "text"},
},
})

if err != nil {
t.Errorf("%v", err)
Expand All @@ -7423,11 +7434,11 @@ func TestClient_CustomFields_Fail(t *testing.T) {

gock.New(crmURL).
Get("/custom-fields").
MatchParam("filter[type]", codeFail).
MatchParam("filter[type][]", codeFail).
Reply(400).
BodyString(`{"success": false, "errorMsg": "Errors in the input parameters"}`)

data, _, err := c.CustomFields(CustomFieldsRequest{Filter: CustomFieldsFilter{Type: codeFail}})
data, _, err := c.CustomFields(CustomFieldsRequest{Filter: CustomFieldsFilter{Type: []string{codeFail}}})
if err == nil {
t.Errorf("%v", err)
}
Expand Down
12 changes: 6 additions & 6 deletions filters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,12 +420,12 @@ type FilesFilter struct {

// CustomFieldsFilter type.
type CustomFieldsFilter struct {
Name string `url:"name,omitempty"`
Code string `url:"code,omitempty"`
Type string `url:"type,omitempty"`
Entity string `url:"entity,omitempty"`
ViewMode string `url:"viewMode,omitempty"`
DisplayArea string `url:"displayArea,omitempty"`
Name string `url:"name,omitempty"`
Code string `url:"code,omitempty"`
Type []string `url:"type,omitempty,brackets"`
Entity string `url:"entity,omitempty"`
ViewMode string `url:"viewMode,omitempty"`
DisplayArea string `url:"displayArea,omitempty"`
}

// CustomDictionariesFilter type.
Expand Down
Loading