Added: Thread exception hook for logging#1960
Open
oliv3r wants to merge 1 commit into
Open
Conversation
Without a custom threading.excepthook, unhandled exceptions in background threads are dispatched to Python's default handler, which writes to stderr. In a Kodi environment this output is typically discarded, meaning thread failures go completely unnoticed and cannot be diagnosed from the add-on log. WebDialogue already spawns a daemon thread to run its HTTP server, and as we expand the use of background threads we need these failures to surface in Retrospect's own log rather than be silently dropped. Installing the hook at add-on startup ensures any unhandled thread exception is captured and logged with a full traceback through the normal Logger path. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
|
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment on it to reset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a custom threading.excepthook, unhandled exceptions in background threads are dispatched to Python's default handler, which writes to stderr. In a Kodi environment this output is typically discarded, meaning thread failures go completely unnoticed and cannot be diagnosed from the add-on log.
WebDialogue already spawns a daemon thread to run its HTTP server, and as we expand the use of background threads we need these failures to surface in Retrospect's own log rather than be silently dropped. Installing the hook at add-on startup ensures any unhandled thread exception is captured and logged with a full traceback through the normal Logger path.