Skip to content

Expand ARCHITECTURE.md: matching hash, auto-issuance, stage mapping#78

Merged
mejango merged 1 commit intomainfrom
docs/architecture-10-of-10
Mar 22, 2026
Merged

Expand ARCHITECTURE.md: matching hash, auto-issuance, stage mapping#78
mejango merged 1 commit intomainfrom
docs/architecture-10-of-10

Conversation

@mejango
Copy link

@mejango mejango commented Mar 22, 2026

Summary

  • Expand the matching hash section: explain how it is computed (incremental ABI encoding + keccak256), which fields it covers (base currency, name, ticker, salt, all per-stage economic fields, all auto-issuance entries), and why splits are excluded (chain-specific addresses). Explain how the hash is used as a CREATE2 salt component for sucker deployment to enforce cross-chain config parity.
  • Expand the auto-issuance section: explain the REVAutoIssuance struct, chainId-based filtering at deploy time, deferred claiming via autoIssueFor, and stage ID assignment.
  • Add a "Stage-to-Ruleset Mapping" section with a field-by-field table showing how REVStageConfig maps to JBRulesetConfig, plus the automatically-set metadata fields.
  • Add two new Key Design Decisions entries (deferred auto-issuance rationale, no approval hook rationale).

Test plan

  • Verify all field mappings against _makeRulesetConfiguration in REVDeployer.sol
  • Verify matching hash field list against _makeRulesetConfigurations encoding logic
  • Verify auto-issuance flow against autoIssueFor function

🤖 Generated with Claude Code

…apping

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mejango mejango merged commit 72a4a35 into main Mar 22, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant