Skip to content

docs: SKILLS.md quality improvements#79

Merged
mejango merged 2 commits intomainfrom
docs/skills-quality-pass
Mar 22, 2026
Merged

docs: SKILLS.md quality improvements#79
mejango merged 2 commits intomainfrom
docs/skills-quality-pass

Conversation

@mejango
Copy link

@mejango mejango commented Mar 22, 2026

Summary

  • Permissions column added to all Key Functions tables -- each function row now specifies its access control (Permissionless, Split operator, Loan NFT owner, Contract owner, Terminal callback, or View). Verified against source contract modifiers.
  • Visibility column added to Storage tables -- each mapping/variable shows public (auto-getter) or internal (no auto-getter, use explicit view function). Cross-referenced with REVDeployer.sol and REVLoans.sol declarations.
  • "Reading Revnet State" section added -- quick-reference tables for the view functions an integrator or agent would call to check current stage, split operator, token supply, surplus, auto-issuance remaining, loan details, and deployer config.
  • Gotcha Refactor/router terminal permissions #17 trimmed -- the loan fee model gotcha previously duplicated details already present in the Constants table. Consolidated to a brief cross-reference.

Test plan

  • Verify all Permissions column values match source access modifiers
  • Verify all Visibility column values match Solidity declarations
  • Confirm Reading Revnet State function signatures compile against interfaces

🤖 Generated with Claude Code

mejango and others added 2 commits March 22, 2026 12:37
…apping

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add Permissions column to all Key Functions tables (verified against source)
- Add Visibility column to Storage tables (public/internal from contract declarations)
- Add "Reading Revnet State" quick-reference section with view function signatures
- Trim Gotcha #17 (loan fee model) to cross-reference Constants table

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mejango mejango merged commit 1421327 into main Mar 22, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant