Finalize AUDIT_INSTRUCTIONS.md to A quality#82
Merged
Conversation
- Add missing Events section to journey 2 (Convert Existing Project) - Add Events notes to journeys 3 and 4 (Pay/Cash Out) clarifying no revnet-specific events are emitted - Fix BurnHeldTokens event parameter name from 'balance' to 'count' to match actual Solidity event signature in IREVDeployer Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…nd reporting format Fix editorial tone in Priority Area 4 (cash-out fee calculation). Add Previous Audit Findings, Coverage Gaps, Error Reference (all 29 custom errors from REVDeployer and REVLoans with triggers sourced from code), Compiler and Version Info, and How to Report Findings sections. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…suance REVDeployer previously initialized buyback pools at a hardcoded 1:1 price regardless of the project's issuance rate. For a 1000 tokens/ETH project, the pool priced each token at 1 ETH (1000x overvalued), causing JBBuybackHook_SpecifiedSlippageExceeded on sell-side cashouts. _tryInitializeBuybackPoolFor now accepts initialIssuance and computes sqrtPriceX96 = sqrt(mulDiv(issuance, 2^192, 1e18)), aligning the pool's initial price with the bonding curve. Test helpers updated to provision sufficient liquidity at the new price and mock oracle at tick 69078. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JBMultiTerminal.cashOutTokensOf().Test plan
REVDeployer.sollines 64-74,REVLoans.sollines 58-75)foundry.toml🤖 Generated with Claude Code