This repository was archived by the owner on May 10, 2018. It is now read-only.
Moving controls to templateCache#304
Open
raphaelluchini wants to merge 5 commits into
Open
Conversation
Owner
|
Hey, nice addition thanks, but looks like you didnt work on the last master version ? |
…into revolunet-master Conflicts: dist/angular-carousel.js dist/angular-carousel.min.js
Contributor
Author
|
It's ok now? |
Owner
|
looks like some code is missing. from your branch you should : git remote add upstream https://github.com/revolunet/angular-carousel.git
git fetch upstream
git rebase upstream/master
git push |
Adds rn-carousel-default-index attribute
…rousel Conflicts: dist/angular-carousel.js dist/angular-carousel.min.js
Contributor
Author
|
Hello @revolunet, can you merge now? ;) Thanks |
Owner
|
looks like there is additional code, apart from the templateCache stuff ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving controls inline html to $templateCache to be possible overwrite them