This repository was archived by the owner on May 10, 2018. It is now read-only.
Change scope.$apply to scope.$digest#402
Open
rodrigolourenco wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading about $apply and $digest on angular communitty, i found that the use of these method's and the impact of launching them concurrently. For example, on my code/test's i launch digest to check the carousel change, but when i do this angular give me an error like this: "https://docs.angularjs.org/error/$rootScope/inprog?p0=$digest". So i change the code to trigger a $digest cycle, not a $apply after read this article "http://www.benlesh.com/2013/08/angularjs-watch-digest-and-apply-oh-my.html". In the case of the carousel, the $apply just have to change the carousel itself and not the entire view, because of this, than i change to $digest.
Thank u !
Best regards from Brasil