Skip to content

Workaround virtiolog (fix empty virt-install.log) gh1763 #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rvykydal merged 3 commits into from
Sep 30, 2026
Merged

Workaround virtiolog (fix empty virt-install.log) gh1763 #1770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e3b097
Update virtio channel rsyslog target as workaround for gh1763
rvykydal Sep 30, 2026
07c9e67
Revert "Disable rpm-ostree-container-siverblue (gh1758)"
rvykydal Sep 30, 2026
12f7a1d
Revert "Disable script-pre* on fedora and fedora-eln for gh1757"
rvykydal Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions containers/runner/skip-testtypes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ fedora_disabled_array=(
gh1530 # dns-global-exclusive-tls-* stage2-from-compose failing
gh1618 # packages-multilib failing on daily-iso
gh1633 # rpm-ostree-container-uefi failing with Fedora 44 runner container
gh1757 # script-pre* failing
gh1758 # rpm-ostree-container-silverblue failing
)

daily_iso_disabled_array=(
Expand Down Expand Up @@ -133,7 +131,6 @@ fedora_eln_disabled_array=(
gh1534 # proxy-cmdline
gh1541 # flatpak-preinstall-* not implemented
gh1574 # bootc-* failing
gh1757 # script-pre* failing
)

# used in workflows/daily-boot-iso-rhel8.yml
Expand Down
5 changes: 4 additions & 1 deletion functions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,10 @@ enable_uefi() {

EXTRA_BOOTOPTS=$(echo "${KSTEST_EXTRA_BOOTOPTS}" | tr ';' ' ')

DEFAULT_BASIC_BOOTOPTS="debug=1 inst.debug ${EXTRA_BOOTOPTS}"
# Workaround for https://github.com/rhinstaller/kickstart-tests/issues/1763
GH_1763_WORKAROUND_BOOTOPT="inst.virtiolog=/dev/vport2p1"

DEFAULT_BASIC_BOOTOPTS="debug=1 inst.debug ${GH_1763_WORKAROUND_BOOTOPT} ${EXTRA_BOOTOPTS}"

DEFAULT_DRACUT_BOOTOPTS="rd.shell=0 rd.emergency=poweroff"

Expand Down
2 changes: 1 addition & 1 deletion rpm-ostree-container-silverblue.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

# Ignore unused variable parsed out by tooling scripts as test tags metadata
# shellcheck disable=SC2034
TESTTYPE="payload ostree skip-on-rhel skip-on-centos skip-on-fedora-eln gh1758"
TESTTYPE="payload ostree skip-on-rhel skip-on-centos skip-on-fedora-eln"

. ${KSTESTDIR}/functions.sh

Expand Down
2 changes: 1 addition & 1 deletion script-pre-install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

# Ignore unused variable parsed out by tooling scripts as test tags metadata
# shellcheck disable=SC2034
TESTTYPE="ksscript textui gh1757"
TESTTYPE="ksscript textui"

. ${KSTESTDIR}/functions.sh

Expand Down
2 changes: 1 addition & 1 deletion script-pre.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

# Ignore unused variable parsed out by tooling scripts as test tags metadata
# shellcheck disable=SC2034
TESTTYPE="ksscript gh1757"
TESTTYPE="ksscript"

. ${KSTESTDIR}/functions.sh

Expand Down
Loading