Retry assisted-installer host wait on transient API failures - #185
Merged
Conversation
The wait_for_hosts module json-parses the assisted-installer API response and crashes on a transient empty or non-JSON reply (Expecting value: line 1 column 1). Seen on prod1 jobs 37314 and 41144 (agd-v2.rhacs-demo-cnv), killing provisions about 90 seconds in. Wrap the task in until/retries as a defensive measure; the durable fix is response-tolerant retry inside the collection module. RHDPOPS-23814 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
agonzalezrh
approved these changes
Jul 16, 2026
1 task
agonzalezrh
pushed a commit
to redhat-cop/agnosticd
that referenced
this pull request
Jul 16, 2026
The rhpds.assisted_installer.wait_for_hosts module crashes on transient empty or non-JSON API responses instead of retrying. Wraps the task in until/retries (3 x 20s) as a defensive measure. The configure_hosts operations are idempotent so re-runs are safe. Mirrors rhpds/agnosticd-v2#185 for v1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rhpds.assisted_installer.wait_for_hosts module json-parses the assisted-installer API response and crashes on a transient empty or non-JSON reply ('Expecting value: line 1 column 1 (char 0)') instead of retrying. This killed agd-v2.rhacs-demo-cnv provisions about 90 seconds into the workload on prod1 jobs 37314 (2026-07-14) and 41144 (2026-07-15).
This wraps the task in until/retries (3 x 20s) as a defensive measure. The module's configure_hosts operations are idempotent (hostname/role assignment), so a re-run after a transient API failure is safe. The durable fix is response-tolerant retry inside the collection module itself (rhpds/assisted_installer, would need a v0.0.10 tag plus requirements bumps in the items pinning v0.0.9).
Campaign tracker: RHDPOPS-23814 (this is flake 2; flake 1 is DNS negative caching, fixed in rhpds/core_workloads#163 plus GPTEINFRA-17341 / GPTEINFRA-17342).