feat(gitops_bootstrap): add configurable sync_options - #168
Closed
tonykay wants to merge 2 commits into
Closed
Conversation
…ication Add ocp4_workload_gitops_bootstrap_sync_options list variable that allows catalog items to add custom syncOptions to the generated ArgoCD Application. RespectIgnoreDifferences=true is always included as before. Common use case: SkipDryRunOnMissingResource=true is needed when operator Subscriptions and their CRDs (e.g. Securesign) are in the same Application. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tonykay
requested review from
agonzalezrh,
fridim,
rut31337,
stencell and
wkulhanek
as code owners
August 5, 2026 14:17
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
I think this is unnecessary. I recommend adding For example, such as in this case: https://github.com/rhpds/modernize-ocp-virt-automation/blob/f665ac11579301e692ec797f58e11e0be2287396/bootstrap-infra/templates/devhub/backstage-cr.yaml#L8 |
Contributor
Author
|
Closing — per Juliano's recommendation, the per-resource annotation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ocp4_workload_gitops_bootstrap_sync_optionslist variable to theocp4_workload_gitops_bootstraprolesyncOptionsto the generated ArgoCD ApplicationRespectIgnoreDifferences=trueis always included (backwards compatible)Motivation
When an ArgoCD Application includes both operator Subscriptions and CRs that depend on those operators' CRDs (e.g. RHTAS
SecuresignCR in the same app as therhtas-operatorSubscription), the dry-run fails because the CRD doesn't exist yet at dry-run time.SkipDryRunOnMissingResource=trueis the standard ArgoCD solution, but the current template has no way to set it.Usage
Test plan
🤖 Generated with Claude Code