feat(ocp4_workload_showroom): support both terminals and add ocp-terminal alias - #77
Merged
Merged
Conversation
…p-terminal Add `both` as a valid value for `ocp4_workload_showroom_terminal_type` so that ocp-terminal (ttyd sandbox) and wetty (SSH to bastion) can run simultaneously in the same showroom pod. Also add `ocp-terminal` as the preferred name (replacing the confusing `showroom` alias which conflicts with the platform name). The old `showroom` value continues to work for backward compatibility. Update default terminal image to pinned tag `quay.io/rhpds/openshift-showroom-terminal-ocp:4.20-2026-08-05`. Co-authored-by: Cursor <cursoragent@cursor.com>
hararora123
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bothas a valid value forocp4_workload_showroom_terminal_typeso that ocp-terminal (ttyd sandbox) and wetty (SSH to bastion) can run simultaneously in the same showroom podocp-terminalas the preferred name for the ttyd terminal type (the oldshowroomvalue was confusing since "showroom" is also the platform name)showroomcontinues to work as a deprecated alias -- zero impact on existing configsquay.io/rhpds/openshift-showroom-terminal-ocp:4.20-2026-08-05Backward Compatibility
All existing
terminal_typevalues produce identical results:terminal_typeshowroom(deprecated)ocp-terminal(new)wettyboth(new)""/noneVerified against ~85 agnosticv configs that set this variable.
Test plan
terminal_type: showroom-- verify ocp-terminal runs, wetty does not (backward compat)terminal_type: ocp-terminal-- same behavior as showroomterminal_type: wetty-- verify wetty runs, ocp-terminal does notterminal_type: both-- verify both containers run and are accessible at/terminaland/wettyterminal_type: ""-- verify neither runsMade with Cursor