JOSS Paper Reorganization#134
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## joss #134 +/- ##
=======================================
Coverage ? 81.92%
=======================================
Files ? 11
Lines ? 354
Branches ? 0
=======================================
Hits ? 290
Misses ? 64
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sjbradshaw @jwreep @schonfsj @nabobalis Feel free to add any suggested revisions here or markup the attached PDF (see link below). It is the same as the one I sent by email. |
| This approximation is valid for bulk velocities below the local sound speed [@klimchuk_highly_2008]. | ||
|
|
||
| The original software implementation of the EBTEL model of @klimchuk_highly_2008 was in the proprietary Interactive Data Language (IDL). | ||
| The EBTEL model was originally developed by @klimchuk_highly_2008. |
There was a problem hiding this comment.
My only comment is that I think (if space allows) it is worth mentioning that the original is in IDL. Being open-source (both language and model) is an excellent improvement that allows students and non-experts to pick it up and use it readily.
There was a problem hiding this comment.
I agree. I've just moved that discussion to the "Software Design" section. There is also some discussion of it in the "State of the Field" section.
3 participants
This PR reorganizes the JOSS paper to fit the new format required by the journal. See this comment on the paper pre-review for more details: openjournals/joss-reviews#9399 (comment)