🛡️ Sentinel: [HIGH/ENHANCEMENT] Strengthen cryptographic operations and session management

.gitignore

@@ -30,4 +30,5 @@ log.txt
 .vscode
 secureData*.txt
 logfile.txt
+logfileConf.txt
 rmc_log.txt

.jules/sentinel.md

@@ -0,0 +1,4 @@
+## 2026-02-05 - Session ID Predictability and Timing Attacks
+**Vulnerability:** ServletManager generated session cookies using only predictable client information (IP, User-Agent, JSESSIONID) without a server-side secret. Also, multiple classes used non-constant-time string comparisons for sensitive tokens and hashes.
+**Learning:** Security mechanisms like session hijacking protection can be bypassed if the generation logic depends only on publicly available or predictable information. Timing attacks are often overlooked in standard string comparisons.
+**Prevention:** Always incorporate a server-side secret (salt) when generating session identifiers or security tokens. Use MessageDigest.isEqual for all cryptographic comparisons to ensure constant-time execution.

JFramework/crypto/src/main/java/it/richkmeli/jframework/crypto/algorithm/SHA256.java

@@ -2,6 +2,7 @@
 
 import org.bouncycastle.crypto.digests.SHA256Digest;
 import it.richkmeli.jframework.util.TypeConverter;
+import java.nio.charset.StandardCharsets;
 
 public class SHA256 {
     public static byte[] hash(byte[] input) {
@@ -15,7 +16,7 @@ public static byte[] hash(byte[] input) {
 
     // sha256: string to hex
     public static String hash(String input) {
-        return TypeConverter.bytesToHex(hash(input.getBytes()));
+        return TypeConverter.bytesToHex(hash(input.getBytes(StandardCharsets.UTF_8)));
     }
 
     public static String hashToString(byte[] input) {

JFramework/crypto/src/main/java/it/richkmeli/jframework/crypto/controller/PasswordManager.java

@@ -3,7 +3,8 @@
 import it.richkmeli.jframework.crypto.algorithm.SHA256;
 import it.richkmeli.jframework.util.RandomStringGenerator;
 
-import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.security.MessageDigest;
 import java.util.Base64;
 
 public class PasswordManager {
@@ -26,20 +27,20 @@ public static String hashPassword(String password, boolean saltEnabled) {
 
         //System.out.println("hashPassword, saltS: " + saltS + " " + saltS.length() + " | hashedPassword: " + hashedPassword + " " + hashedPassword.length());
         String out = saltS + hashedPassword;
-        return Base64.getUrlEncoder().encodeToString(out.getBytes(Charset.defaultCharset()));
+        return Base64.getUrlEncoder().encodeToString(out.getBytes(StandardCharsets.UTF_8));
     }
 
     // hashedPassword = db password, hashedSaltPassword = login password
     public static boolean verifyPassword(String hashedPassword, String hashedSaltPassword) {
-        String decodedHashedPassword = new String(Base64.getUrlDecoder().decode(hashedPassword));
-        String decodedHashedSaltPassword = new String(Base64.getUrlDecoder().decode(hashedSaltPassword));
+        String decodedHashedPassword = new String(Base64.getUrlDecoder().decode(hashedPassword), StandardCharsets.UTF_8);
+        String decodedHashedSaltPassword = new String(Base64.getUrlDecoder().decode(hashedSaltPassword), StandardCharsets.UTF_8);
         String salt = decodedHashedSaltPassword.substring(0, 9);
         String hashSP = decodedHashedSaltPassword.substring(9);
         String hashP = decodedHashedPassword.substring(9);
 
         //System.out.println("verifyPassword, saltS: " + salt + " " + salt.length() + " | hashedSaltPassword: " + hashSP + " " + hashSP.length());
         String hp = SHA256.hash(hashP + salt);
 
-        return hashSP.equalsIgnoreCase(hp);
+        return MessageDigest.isEqual(hashSP.getBytes(StandardCharsets.UTF_8), hp.getBytes(StandardCharsets.UTF_8));
     }
 }

JFramework/crypto/src/main/java/it/richkmeli/jframework/crypto/controller/token/TokenManager.java

@@ -4,6 +4,8 @@
 import it.richkmeli.jframework.crypto.exception.CryptoException;
 import it.richkmeli.jframework.util.RandomStringGenerator;
 
+import java.nio.charset.StandardCharsets;
+import java.security.MessageDigest;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
@@ -29,7 +31,7 @@ public static boolean verifyNumericCompact(String numericCompactToken, String va
          String extendedToken = generate(extractedNumericSalt + value, false);
         // put extractedNumericSalt at first chars of extendedToken
         extendedToken = reduceToNumeric(extractedNumericSalt + extendedToken, numericCompactToken.length());
-        return numericCompactToken.equalsIgnoreCase(extendedToken);
+        return MessageDigest.isEqual(numericCompactToken.getBytes(StandardCharsets.UTF_8), extendedToken.getBytes(StandardCharsets.UTF_8));
     }
 
     public static String generate(String value) {
@@ -109,7 +111,7 @@ public static boolean verifyTemporized(String token, String value, int minutesOf
             hashed = token;
             calculatedHash = SHA256.hash(value + (currentTimeMinutes * minutesOfValidity));
         }
-        return hashed.equalsIgnoreCase(calculatedHash);
+        return MessageDigest.isEqual(hashed.getBytes(StandardCharsets.UTF_8), calculatedHash.getBytes(StandardCharsets.UTF_8));
     }
 
     private static String reduceToNumeric(String extendedToken, int length) {

JFramework/network/src/main/java/it/richkmeli/jframework/network/tcp/server/http/util/ServletManager.java

@@ -14,6 +14,8 @@
 import javax.servlet.http.HttpServletResponse;
 import javax.servlet.http.HttpSession;
 import java.io.BufferedReader;
+import java.nio.charset.StandardCharsets;
+import java.security.MessageDigest;
 import java.io.IOException;
 import java.io.PrintWriter;
 import java.util.*;
@@ -128,12 +130,18 @@ public static void initSessionCookie(HttpServletRequest request, HttpServletResp
             //Logger.info("Cookie JFRAMEWORKSESSIONID: already present");
             cookie = getCookie(request, JFSESSIONID);
         } else {
-            String id = request.getRemoteAddr()
+            String encryptionKey = "default_secret_salt";
+            try {
+                encryptionKey = ResourceBundle.getBundle("configuration").getString("encryptionkey");
+            } catch (Exception e) {
+                // encryptionKey remains "default_secret_salt"
+            }
+            String id = encryptionKey + "##" + request.getRemoteAddr()
                     //+ "##" + request.getRemoteUser()
                     + "##" + getCookie(request, "JSESSIONID").getValue()
                     + "##" + request.getHeader("User-Agent");
             //Logger.info("Cookie JFRAMEWORKSESSIONID: " + id);
-            String hashed = SHA256.hashToString(id.getBytes());
+            String hashed = SHA256.hashToString(id.getBytes(StandardCharsets.UTF_8));
             cookie = new Cookie(JFSESSIONID, hashed);
             //cookie.setMaxAge(JFSESSIONCOOKIE_MAXAGE);
         }
@@ -152,9 +160,16 @@ public static Cookie generateSessionCookie(HttpServletRequest request) {
         }
         String userAgent = request.getHeader("User-Agent");
 
-        String id = remoteAddr + "##" + jsessionid + "##" + userAgent;
+        String encryptionKey = "default_secret_salt";
+        try {
+            encryptionKey = ResourceBundle.getBundle("configuration").getString("encryptionkey");
+        } catch (Exception e) {
+            // encryptionKey remains "default_secret_salt"
+        }
+
+        String id = encryptionKey + "##" + remoteAddr + "##" + jsessionid + "##" + userAgent;
         //Logger.info("Cookie JFRAMEWORKSESSIONID: " + id);
-        String hashed = SHA256.hashToString(id.getBytes());
+        String hashed = SHA256.hashToString(id.getBytes(StandardCharsets.UTF_8));
         return new Cookie(JFSESSIONID, hashed);
     }
 
@@ -168,7 +183,7 @@ public static void checkSessionCookie(HttpServletRequest request, HttpServletRes
             //response.reset();
             throw new JServletException(new KoResponse(BaseStatusCode.JFRAMEWORK_SESSIONID_ERROR));
         }
-        if (!extractedJframeworkSessionID.getValue().equalsIgnoreCase(generateSessionCookie(request).getValue())) {
+        if (!MessageDigest.isEqual(extractedJframeworkSessionID.getValue().getBytes(StandardCharsets.UTF_8), generateSessionCookie(request).getValue().getBytes(StandardCharsets.UTF_8))) {
             String error = "JFRAMEWORKSESSIONID mismatch, possible Session Hijacking Attack";
             Logger.error(error);
             resetSession(request, response);

JFramework/util/src/main/java/it/richkmeli/jframework/util/RandomStringGenerator.java

@@ -4,6 +4,7 @@
 import java.security.SecureRandom;
 
 public class RandomStringGenerator {
+    private static final SecureRandom secureRandom = new SecureRandom();
     public static final String ALPHANUMERIC_ALPHABET = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";
     public static final String NUMERIC_ALPHABET = "0123456789";
 
@@ -21,7 +22,6 @@ private static String generateString(int length, String alphabet) {
         int alphabetLength = alphabet.length();
 
         StringBuilder result = new StringBuilder();
-        SecureRandom secureRandom = new SecureRandom();
 
         for (int i = 0; i < length; ++i) {
             result.append(alphabet.charAt(secureRandom.nextInt(alphabetLength)));
@@ -42,11 +42,10 @@ public static String generateBoundedString(int targetStringLength, int leftLimit
         //int leftLimit = 97; // letter 'a'
         //int rightLimit = 122; // letter 'z'
         //int targetStringLength = 10;
-        SecureRandom random = new SecureRandom();
         StringBuilder buffer = new StringBuilder(targetStringLength);
         for (int i = 0; i < targetStringLength; i++) {
             int randomLimitedInt = leftLimit + (int)
-                    (random.nextFloat() * (rightLimit - leftLimit + 1));
+                    (secureRandom.nextFloat() * (rightLimit - leftLimit + 1));
             buffer.append((char) randomLimitedInt);
         }
         return buffer.toString();
@@ -55,19 +54,19 @@ public static String generateBoundedString(int targetStringLength, int leftLimit
 
     public static String generateUtf8String(int length) {
         byte[] array = new byte[length]; // length is bounded by 7
-        new SecureRandom().nextBytes(array);
+        secureRandom.nextBytes(array);
         return new String(array, StandardCharsets.UTF_8);
     }
 
     public static String generateUtf16String(int length) {
         byte[] array = new byte[length]; // length is bounded by 7
-        new SecureRandom().nextBytes(array);
+        secureRandom.nextBytes(array);
         return new String(array, StandardCharsets.UTF_16);
     }
 
     public static String generateASCIItring(int length) {
         byte[] array = new byte[length]; // length is bounded by 7
-        new SecureRandom().nextBytes(array);
+        secureRandom.nextBytes(array);
         return new String(array, StandardCharsets.US_ASCII);
     }