fix(proxmox): complete the Installed mark when sync marks a VM running (#26)#28
Merged
Merged
Conversation
#26) The Proxmox sync daemon (90s loop) marks a running VM Installed but only set status.state — leaving os_installed=None and progress<100 when the eager pre-reboot workflow-event mark was lost (network blip / agent crash before the notification landed). A sync-marked Installed box then failed Jetpack's checks and the reimage OS-fallback had nothing to resolve to. Extract apply_proxmox_vm_state(): when a VM reports 'running', also complete the mark (os_installed from os_choice, os_choice cleared, progress 100), mirroring the workflow-event path. Every running Proxmox VM now reaches a whole Installed state within the sync window regardless of whether the pre-reboot notification landed. +4 unit tests (apply_proxmox_vm_state extracted as a free fn). Companion to riffcc/jetpack#39 (converge never implicitly reimages). Refs: #26 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dragonfly #26 — server-side companion to riffcc/jetpack#39.
The Proxmox sync daemon marks a running VM
Installed, but only setstatus.state— leavingos_installed = Noneandprogress < 100when the eager pre-reboot workflow-event mark was lost. A sync-markedInstalledbox then failed Jetpack's checks and the reimage OS-fallback had nothing to resolve to.Fix: extract
apply_proxmox_vm_state(); when a VM reportsrunning, complete the mark (os_installedfromos_choice, clearos_choice,progress = 100), mirroring the workflow-event path. Every running Proxmox VM now reaches a wholeInstalledstate within the ~90s sync window regardless of whether the pre-reboot notification landed.+4 unit tests (
apply_proxmox_vm_stateextracted as a free fn for testability).🤖 Generated with Claude Code