Skip to content

Fix shard router live config reload#942

Merged
RUKAYAT-CODER merged 2 commits into
rinafcode:mainfrom
Jerry-Tekh:fix/shard-router-live-reload
Jul 2, 2026
Merged

Fix shard router live config reload#942
RUKAYAT-CODER merged 2 commits into
rinafcode:mainfrom
Jerry-Tekh:fix/shard-router-live-reload

Conversation

@Jerry-Tekh

Copy link
Copy Markdown
Contributor

Summary

  • add runtime shard config reload and Redis pub/sub listener for shard:config:updated
  • swap immutable routing snapshots atomically during ring rebuilds
  • add /sharding/reload admin endpoint and live-reload routing coverage

Tests

  • npm test -- shard-router.spec.ts --runInBand --detectOpenHandles
  • npm run typecheck

Closes #813

@drips-wave

drips-wave Bot commented Jun 29, 2026

Copy link
Copy Markdown

@Jerry-Tekh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

Great job so far

There’s just one blocker — the workflow is failing. Could you take a look and fix it so all checks pass?

Happy to review again once that’s done.

@Jerry-Tekh

Jerry-Tekh commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Great job so far

There’s just one blocker — the workflow is failing. Could you take a look and fix it so all checks pass?

Happy to review again once that’s done.

it is resoled now ,you can check . thank you so much . looking forward to bringing in more contribution.

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

Thank you for contributing to the project.

@RUKAYAT-CODER RUKAYAT-CODER merged commit c1799af into rinafcode:main Jul 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shard consistent-hash ring is only built at startup with no live reload

2 participants