fix(auth): wire heroImage prop into AuthLayout hero section#875
Merged
RUKAYAT-CODER merged 1 commit intoJun 30, 2026
Merged
Conversation
|
@extolkom Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #754
PR Description
Title: [Tech-debt] Wire heroImage prop into AuthLayout hero section
Summary
AuthLayout.tsx declared a heroImage prop and destructured it, but immediately discarded it with void heroImage, rendering a hardcoded background instead. This made the component's public API misleading — callers could pass a heroImage and reasonably expect it to be used, but it had no effect.
Changes
Wired heroImage into the hero section using next/image, so the prop now actually controls the rendered image.
Removed the void heroImage suppressant now that the prop is genuinely used.
Updated all call sites passing heroImage to AuthLayout to confirm they render as expected with the new behavior.
Updated any stories/tests referencing the heroImage prop to reflect the real rendering instead of the previous no-op.
Why
Keeps the component's interface honest — a prop that's accepted should affect output. Removing dead suppressants also avoids masking future unused-variable issues introduced by mistake.
Testing
Verified locally that passing different heroImage values updates the rendered hero image as expected, and that omitting it falls back sensibly. Ran type-check and existing test/story suite — no unused-variable errors, all green.
Acceptance criteria met
✅ heroImage is rendered in the hero section via next/image
✅ No void propName suppressants remain in the component
✅ TypeScript compilation shows no unused-variable errors