Skip to content

fix(auth): wire heroImage prop into AuthLayout hero section#875

Merged
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
extolkom:fix/754-authlayout-heroimage-prop
Jun 30, 2026
Merged

fix(auth): wire heroImage prop into AuthLayout hero section#875
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
extolkom:fix/754-authlayout-heroimage-prop

Conversation

@extolkom

Copy link
Copy Markdown
Contributor

closes #754

PR Description
Title: [Tech-debt] Wire heroImage prop into AuthLayout hero section
Summary
AuthLayout.tsx declared a heroImage prop and destructured it, but immediately discarded it with void heroImage, rendering a hardcoded background instead. This made the component's public API misleading — callers could pass a heroImage and reasonably expect it to be used, but it had no effect.
Changes

Wired heroImage into the hero section using next/image, so the prop now actually controls the rendered image.
Removed the void heroImage suppressant now that the prop is genuinely used.
Updated all call sites passing heroImage to AuthLayout to confirm they render as expected with the new behavior.
Updated any stories/tests referencing the heroImage prop to reflect the real rendering instead of the previous no-op.

Why
Keeps the component's interface honest — a prop that's accepted should affect output. Removing dead suppressants also avoids masking future unused-variable issues introduced by mistake.
Testing
Verified locally that passing different heroImage values updates the rendered hero image as expected, and that omitting it falls back sensibly. Ran type-check and existing test/story suite — no unused-variable errors, all green.
Acceptance criteria met

✅ heroImage is rendered in the hero section via next/image
✅ No void propName suppressants remain in the component
✅ TypeScript compilation shows no unused-variable errors

@drips-wave

drips-wave Bot commented Jun 30, 2026

Copy link
Copy Markdown

@extolkom Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

Thank you for contributing to the project.

@RUKAYAT-CODER RUKAYAT-CODER merged commit c959939 into rinafcode:main Jun 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tech-debt] heroImage prop is accepted but immediately discarded in AuthLayout.tsx

2 participants