ZKVM-1191: Refactor Clap attribute macros #3010
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
@Himess is attempting to deploy a commit to the RISC Zero Team on Vercel. A member of the Team first needs to authorize it. |
Himess
changed the title
Himess
force-pushed
the
fix/deprecated-clap-attribute-v2
branch
from
cf82ec2 to
c9c7c98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates another deprecated
#[clap(...)]attribute to its modern equivalent#[command(...)], as introduced in clap 4.x.Previously, in #2945 , I fixed all known instances of the deprecated syntax. However, while running:
cargo check --features clap/deprecateda new usage was found at
rzup/src/cli/commands.rs:273, which caused a build failure due to the usage of the outdated#[clap(group(...))]syntax.This PR ensures consistency across the codebase and avoids future breakages related to deprecated clap attributes.
Fixes #2936