-
Notifications
You must be signed in to change notification settings - Fork 2
created more details page and a table wrapper for making tables #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kersten Richter <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this commit is needed as @BlackstoneEngineering has already taken care of this. (Note this was in reference to commit 754f385.)
I'm also fine with commit d44c1fb staying as Search is pretty stable and the UI impacts are minimal. Now, I'm sure there's things will learn and get to work on, but that's true of everything we'll enable. |
Commits 8701c85 and 04d971f have already been address by @BlackstoneEngineering as well. |
I do like the idea of maintaining the detailed information in a json file. I'll observe that we likely have 2 style templates. A base template that includes community, repo, and history. Then ISA templates have that information, plus information about ratified but not included extensions, and the archived (included) information (with links to standalone docs). |
Think this was an artifact of me merging main in along the way, not sure why it's showing up as my commit now. Same with the other two. |
The only advantage to working in a json file is that the formatting of all these pages becomes templatized and the information just gets presented. We technically are going to have 2 types of templates -- The basic template like I've manually put in PR #49 and the Extended details for the ISA manuals that Daniel has created. Thoughts? |
The links won't work until we upload the new PDFs. Which, BTW, we might want to define a PDF naming structure for these. We decided these should land in Antora, right? |
This creates a "more details" page and populates it with data. The pdf links are all still a WIP on those pages. The link is in the body because it breaks formatting if it is in the footer.