QC suggestions for RC1 (some minor clarifications) #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eckhard-delfs-qualcomm
commented
Sep 16, 2024
eckhard-delfs-qualcomm
commented
- Removal of "allow/disallow" only option from Smmtt34
- adding explicit statement how many SDs are supported by SmMTT
- clarification that permission attribute is "disallowed" not allowed
- ambiguity: "MTT structure accesses" -> MTT checker accesses to MTT structures
- clarification to informative statement on MTT lookups in section 4.4: Chapter 2 states that when Smmtt is implemented, MTT and e(PMP) are always active. Hence the phrases "while active / no longer active" can be misleading.
- allow/disallow mode has been abandoned. - support for up to 64 domains should be mentioned more explicitly. Signed-off-by: eckhard-delfs-qualcomm <[email protected]>
Suggestions to make wording more specific. Regarding informative note: Chapter 2 states that when Smmtt is implemented, MTT and e(PMP) are always active. Hence the phrases "while active / no longer active" may be misleading. Signed-off-by: eckhard-delfs-qualcomm <[email protected]>
typo Signed-off-by: eckhard-delfs-qualcomm <[email protected]>
chapter3.adoc
Outdated
| @@ -113,7 +113,8 @@ every bit position in the `SDID` field, then reading back the value in `mttp` | |||
| to see which bit positions in the `SDID` field hold a one. The | |||
| least-significant bits of `SDID` are implemented first: that is, if `SDIDLEN` > | |||
| 0, `SDID`[`SDIDLEN`-1:0] is writable. The maximal value of `SDIDLEN`, termed | |||
| `SDIDMAX`, is 6 for `Smmtt[34 | 46 | 56]`. | |||
| `SDIDMAX`, is 6 for `Smmtt[34 | 46 | 56]` and consequently allows for up to | |||
| 64 supervisor domains. | |||
There was a problem hiding this comment.
My reading of the spec is that SDIDs are intended to work like ASIDs: they can be reused if you run out, at the cost of requiring a full-address-space fence when repurposing an SDID for a different supervisor domain (either at startup or during the context switch). So there is effectively no limit on the number of active supervisor domains. I have opened #76 to clarify this.
There was a problem hiding this comment.
thats correct - see the comment on the use of SDIDs in that issue #76
rsahita
reviewed
Sep 30, 2024
rsahita
reviewed
Sep 30, 2024
rsahita
reviewed
Sep 30, 2024
rsahita
reviewed
Sep 30, 2024
Signed-off-by: Ravi Sahita <[email protected]>
rsahita
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.