Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address comments in issue 72 #83

Merged
merged 5 commits into from
Oct 2, 2024
Merged

Address comments in issue 72 #83

merged 5 commits into from
Oct 2, 2024

Conversation

ved-rivos
Copy link
Collaborator

No description provided.

@ved-rivos ved-rivos mentioned this pull request Oct 1, 2024
Closed
eckhard-delfs-qualcomm
eckhard-delfs-qualcomm reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@eckhard-delfs-qualcomm eckhard-delfs-qualcomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the example.
(In case ranges sizes of only up to 4GB should be expressed here I think PPN would need to be restricted to [20:0].)

I will quickly feedback on the "limit/restrict" issue.

chapter6.adoc Outdated
====
The following example illustrates the use of `S` field to specify an address
range for the `MTTINVAL` operation. The example shows encoding ranges of up to
4 GiB. Larger ranges may be encoded using the upper address bits (bits 43:22)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4 GiB. Larger ranges may be encoded using the upper address bits (bits 43:22)
8 GiB. Larger ranges may be encoded using the upper address bits (bits 43:22)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to fix the example.

chapter6.adoc Outdated
| `yyyyy yyyyyyyy yyyyyyyy`| 0 | 4 KiB
| `yyyyy yyyyyyyy yyyyyyy0`| 1 | 8 KiB
| `yyyyy yyyyyyy0 11111111`| 1 | 2 MiB
| `yy011 11111111 11111111`| 1 | 1 GiB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `yy011 11111111 11111111`| 1 | 1 GiB
| `yy011 11111111 11111111`| 1 | 2 GiB

chapter6.adoc Outdated
| `yyyyy yyyyyyyy yyyyyyy0`| 1 | 8 KiB
| `yyyyy yyyyyyy0 11111111`| 1 | 2 MiB
| `yy011 11111111 11111111`| 1 | 1 GiB
| `01111 11111111 11111111`| 1 | 4 GiB
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `01111 11111111 11111111`| 1 | 4 GiB
| `01111 11111111 11111111`| 1 | 8 GiB

@eckhard-delfs-qualcomm
Copy link
Contributor

Thanks for adding the example. (In case ranges sizes of only up to 4GB should be expressed here I think PPN would need to be restricted to [20:0].)

I will quickly feedback on the "limit/restrict" issue.

Our feedback has been covered by Andrew in issue #72 (comment)

eckhard-delfs-qualcomm
eckhard-delfs-qualcomm approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@eckhard-delfs-qualcomm eckhard-delfs-qualcomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - thanks!

@rsahita rsahita merged commit 7da1468 into riscv:main Oct 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsahita rsahita rsahita approved these changes

@eckhard-delfs-qualcomm eckhard-delfs-qualcomm eckhard-delfs-qualcomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ved-rivos @eckhard-delfs-qualcomm @rsahita