clarification on SDID as a local identifer #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ravi Sahita <[email protected]>
Closed
ved-rivos
reviewed
Oct 2, 2024
rsahita
commented
Oct 2, 2024
Signed-off-by: Ravi Sahita <[email protected]>
ved-rivos
reviewed
Oct 2, 2024
chapter3.adoc
Outdated
| unique only to a hart, hence, SDID must not be used to tag downstream | ||
| transactions that are globally visible - implementations may map the SDID from | ||
| the initiator to other (global) identifiers but that mapping is | ||
| implementation-specific and out of scope of this specification. |
There was a problem hiding this comment.
We could remove the "implementations may ...." - don't need to suggest an implementation specific thing. Implementations are of course free to do whatever they need but the architecture may not want to encourage that.
Co-authored-by: Samuel Holland <[email protected]> Signed-off-by: Ravi Sahita <[email protected]>
SiFiveHolland
approved these changes
Oct 2, 2024
ved-rivos
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to address issue #76