Fix outside click no longer working after closed once#112
Open
bezbos wants to merge 1 commit intorishabhbhatia:masterfrom
Open
Fix outside click no longer working after closed once#112bezbos wants to merge 1 commit intorishabhbhatia:masterfrom
bezbos wants to merge 1 commit intorishabhbhatia:masterfrom
Conversation
Fixes the issue where you would tap outside the prompt and it would no longer open. This happens because the modal is closed but the state is not updated. My solution was to simply call the `onCancelPressed` which is also called when the "cancel" option is clicked.
Owner
rishabhbhatia
left a comment
rishabhbhatia
left a comment
There was a problem hiding this comment.
hey Boško, check out the onDismiss callback here props. For resetting the state, this should get the job done.
Your thought process was right. For some reason, I don't have it declared in propTypes. But yeah, try it out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue where you would tap outside the prompt and it would no longer open. This happens because the modal is closed but the state is not updated. My solution was to simply call the
onCancelPressedwhich is also called when the "cancel" option is clicked.