Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: start code from 0 #20

Merged
merged 1 commit into from
Jun 30, 2023
Merged

fix: start code from 0 #20

merged 1 commit into from
Jun 30, 2023

Conversation

wjf3121
Copy link
Contributor

@wjf3121 wjf3121 commented Jun 30, 2023

Otherwise, if not specified, CANCELED will be the default code. The fixed error code is also more consistent with gRPC code.

Otherwise, if not specified, CANCELED will be the default code. The
fixed error code is also more consistent with gRPC code.
@wjf3121 wjf3121 requested review from CAJan93 and Gogomoe June 30, 2023 06:45
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #20 (7cac006) into main (4f2f5b9) will increase coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   85.88%   86.03%   +0.15%     
==========================================
  Files           4        4              
  Lines         666      666              
==========================================
+ Hits          572      573       +1     
+ Misses         88       87       -1     
  Partials        6        6              
Flag Coverage Δ
unittests 86.03% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
codes.go 52.94% <ø> (+1.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Gogomoe Gogomoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wjf3121 wjf3121 merged commit 714d5f1 into main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants