Skip to content

Conversation

@zwang28
Copy link
Contributor

@zwang28 zwang28 commented Jun 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR is a quick fix. I went through all tracing:: in connector crate, to find any potential ones.

  1. rdkafka::ClientConfig::conf_map is not strong-typed. This PR simply removes it from log. We may leverage secure-string in the rdkafka lib in the future.
  2. For ConnectorProperties and SinkParam, this PR again simply removes them from log. After SECRETS hopefully there's no more sensitive info in them. The reasons why I don't leverage secure-string now are

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Jun 4, 2024
@zwang28 zwang28 requested review from BugenZhao, fuyufjh and hzxa21 June 4, 2024 02:59
@zwang28 zwang28 added this pull request to the merge queue Jun 4, 2024
Merged via the queue into main with commit 2f0f5f3 Jun 4, 2024
@zwang28 zwang28 deleted the wangzheng/dont_log_props branch June 4, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/fix Type: Bug fix. Only for pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants