feat(sync): add SFTP pull direction#634
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
biwa-docs | 6997c61 | Commit Preview URL Branch Preview URL |
May 18 2026, 06:49 PM |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
===========================================
+ Coverage 41.28% 51.32% +10.04%
===========================================
Files 16 25 +9
Lines 671 2457 +1786
===========================================
+ Hits 277 1261 +984
- Misses 394 1196 +802 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request introduces a pull synchronization mode to biwa, enabling file transfers from a remote host to the local sync root. The changes include adding a --pull flag to the sync command, updating documentation, and implementing the core pull logic with safety guards against unsafe path traversal and symlink manipulation. Review feedback highlights opportunities to improve performance by using asynchronous file system operations and ensuring that local file and directory permissions remain consistent with the project's security policies (0700 for directories and 0600 for files). Additionally, there is a suggestion to refine how the tool handles local symlinks during the pull process to make the synchronization more robust.
5c126fa to
bdac444
Compare
Closes #413.
Summary
biwa sync --pullfor copying eligible remote-generated artifacts back into the local sync root--overwriteis passed--overwritefor explicit pull overwrites, local file deletion, remote-only file creation, and empty-directory mirroringTesting
LINT=true mise run checkcargo test ssh::sync::testscargo test --test ssh_e2e_sync e2e_sync_pull