Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse link switching and plan overflow fix #98

Merged
merged 5 commits into from
May 6, 2017
Merged

Conversation

BenAlderfer
Copy link
Member

@BenAlderfer BenAlderfer commented May 6, 2017

Browse button is now linked when logged in and appears as normal text when not.
Added a possible fix for the safari plan browsing overflow bug but I couldn't test it. @akath20 you'll need to check that

@BenAlderfer BenAlderfer requested review from khanny17 and akath20 May 6, 2017 02:59
edit icon and pointer cursor
@BenAlderfer
Copy link
Member Author

Also just threw in a edit icon and pointer cursor to make it more obvious you can edit plan titles

Copy link
Collaborator

@khanny17 khanny17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, but next time i would favor ng-if over ng-switch, unless you have MANY ng-ifs that all look the same

@khanny17 khanny17 merged commit 6910431 into master May 6, 2017
@khanny17 khanny17 deleted the design-changes branch May 6, 2017 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants