-
Notifications
You must be signed in to change notification settings - Fork 120
fix(backend/frontend): gzip middleware + StreamDetailDrawer Stellar Expert tx links #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ogazboiz
wants to merge
1
commit into
ritik4ever:main
Choose a base branch
from
ogazboiz:fix/364-399-gzip-txhash-links
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+83
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Assert against the specific "Stream created" event row.
Line 458 only caps the total number of tx links on the page, so this still passes if the link moves from the claimed event to the created event. Scope the assertion to the "Stream created" list item and verify that row has no transaction link.
Suggested test shape
it('does not render a tx link when txHash is absent', async () => { render(<StreamDetailDrawer streamId="42" onClose={onClose} />); await waitFor(() => expect(screen.getByText('Stream created')).toBeInTheDocument()); - // "created" event has no txHash — only the "claimed" event has a link - const links = screen.queryAllByRole('link', { name: /View transaction/i }); - expect(links.length).toBeLessThanOrEqual(1); + const createdRow = screen.getByText('Stream created').closest('li'); + expect(createdRow).not.toBeNull(); + expect( + within(createdRow as HTMLElement).queryByRole('link', { name: /View transaction/i }), + ).not.toBeInTheDocument(); });📝 Committable suggestion
🤖 Prompt for AI Agents