chore: fix building hub archive #2368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added external dependencies to esbuild configuration in TypeScript SDK to support hub archive building functionality.
- Added 'js-base64', 'qs', 'url-join', 'form-data', and 'readable-stream' as external dependencies in
/sdks/api/full/typescript/build.js - Dependencies will be required at runtime rather than bundled, ensuring proper module resolution for hub archive building
- Configuration applies across Node.js and browser bundle outputs
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet-hub with
|
| Latest commit: |
713f5db
|
| Status: | ⚡️ Build in progress... |
Deploying rivet-studio with
|
| Latest commit: |
6e95445
|
| Status: | 🚫 Build failed. |
Deploying rivet with
|
| Latest commit: |
ee31618
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://175761b8.rivet.pages.dev |
| Branch Preview URL: | https://04-16-chore-fix-building-hub.rivet.pages.dev |
jog1t
changed the base branch from
04-15-feat_hub_functions
to
graphite-base/2368
NathanFlurry
force-pushed
the
04-16-chore_fix_building_hub_archive
branch
from
6e95445 to
9560f1a
Compare
NathanFlurry
force-pushed
the
graphite-base/2368
branch
from
d569321 to
7de6870
Compare
NathanFlurry
changed the base branch from
graphite-base/2368
to
04-15-feat_hub_functions
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 25, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
changed the base branch from
04-15-feat_hub_functions
to
graphite-base/2368
graphite-app
bot
force-pushed
the
04-16-chore_fix_building_hub_archive
branch
from
9560f1a to
7d575eb
Compare
graphite-app
bot
force-pushed
the
graphite-base/2368
branch
from
7de6870 to
cc22e91
Compare
graphite-app
bot
force-pushed
the
04-16-chore_fix_building_hub_archive
branch
from
7d575eb to
ee31618
Compare
NathanFlurry
force-pushed
the
04-16-chore_fix_building_hub_archive
branch
from
ee31618 to
713f5db
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 25, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes