Skip to content

Conversation

@NicholasKissel
Copy link
Member

chore(site): weekly changelog

chore(site): weekly changelog for October 19th

@vercel
Copy link

vercel bot commented Oct 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-site Ready Ready Preview Comment Oct 29, 2025 9:09pm
rivetkit-serverless Ready Ready Preview Comment Oct 29, 2025 9:09pm
2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
rivet-cloud Ignored Ignored Oct 29, 2025 9:09pm
rivet-inspector Ignored Ignored Preview Oct 29, 2025 9:09pm

Copy link
Member Author

NicholasKissel commented Oct 29, 2025


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Oct 29, 2025

PR Review: Weekly Changelog

Thanks for adding the weekly changelog updates! Here's my review:

Issues Found

1. Inconsistent Dates and Week Numbers

Both changelog posts claim to be for "2025-41" but have different publication dates:

  • 2025-10-19-weekly-updates/page.mdx: Published 2025-10-19, claims week 41
  • 2025-10-24-weekly-updates/page.mdx: Published 2025-10-24, claims week 41

Impact: These should be different weeks. Week 41 of 2025 would be ~Oct 6-12, and week 42 would be ~Oct 13-19. The dates suggest:

  • Oct 19 should be week 42
  • Oct 24 should be week 43

Looking at 2025-10-20-weekly-updates/page.mdx, it correctly uses "2025-42" for Oct 20.

Recommendation: Update the week numbers to match the actual ISO week numbers for the publication dates.

2. Duplicate Content

Both files have nearly identical content (same bullet points), with only a minor difference:

  • Oct 19 version: "- Coolify" (incomplete)
  • Oct 24 version: "- Coolify support added" (complete)

Impact: If these are meant to be two different weeks, they should have different updates. If they're the same week, one should be removed.

Recommendation:

  • If these represent two different weeks, each should have unique updates for that week
  • If they represent the same content with a correction, remove the older/incorrect one

3. Missing Newline at End of File

The file 2025-10-19-weekly-updates/page.mdx is missing a newline at the end (line 10 ends with "Coolify").

Impact: Minor - but most codebases prefer files to end with a newline for better diff readability and POSIX compliance.

Recommendation: Add a newline at the end of the file.

4. biome.json Change Context

The change to biome.json adds !site to the ignore list, but there's already !website in the list.

Question: Is there a separate site/ directory that needs to be ignored? This seems unrelated to the changelog changes. If this is intentional configuration, it should probably be in a separate commit or explained in the PR description.

Positive Observations

✅ Consistent metadata format matching other weekly updates
✅ Appropriate use of keywords
✅ Clean, readable bullet-point format
✅ Binary image file properly added for the Oct 24 post

Recommendations Summary

  1. Fix week numbers to match publication dates (Oct 19 → week 42, Oct 24 → week 43)
  2. Differentiate content between the two posts or remove the duplicate
  3. Add newline at end of 2025-10-19-weekly-updates/page.mdx
  4. Clarify biome.json change - is this intentional or should it be in a separate PR?

Let me know if you need any clarification on these points!

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 29, 2025

More templates

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/actor@3283

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3283

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/core@3283

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3283

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3283

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3283

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3283

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3283

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3283

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3283

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3283

commit: 4551fbb

@claude
Copy link

claude bot commented Oct 29, 2025

PR Review: Weekly Changelog

Thanks for adding the weekly changelog posts! Here's my review:

Issues Found

1. Incorrect Week Number for 2025-10-19

The post 2025-10-19-weekly-updates/page.mdx shows heading "Rivet Weekly Changelog 2025-41" but October 19, 2025 is actually Week 42, not Week 41. Looking at the existing pattern, 2025-10-20 uses "2025-42" (correct) and 2025-10-10 uses "2025-40" (correct).

Fix: Change the heading to "Rivet Weekly Changelog 2025-42"

2. Duplicate Content

Both changelog posts (2025-10-19 and 2025-10-24) have nearly identical content about WebSockets/HTTP path routing, AMD64 Docker image, and Coolify. The only difference is one says "Coolify" and the other "Coolify support added".

If these are meant to be two different weekly updates, they should have different content reflecting what actually shipped in each week. If they're the same week, you should only have one post.

3. Inconsistent Keywords

Both posts use identical keywords. If the posts have different content, they should have different keywords reflecting their specific updates.

4. Missing Newline at End of File

Both new page.mdx files are missing a newline at the end. While minor, this is inconsistent with existing posts (check 2025-10-20-weekly-updates/page.mdx which has a trailing newline).

Positive Notes

  • biome.json update to ignore site directory is correct
  • File structure follows existing patterns
  • Metadata format is consistent with other posts
  • Published dates match folder names

Recommendations

  1. Verify the actual week numbers and update the headings accordingly
  2. Clarify if these are two separate weekly updates or if one should be removed
  3. Ensure each post reflects the actual updates for that specific week
  4. Add trailing newlines to both page.mdx files for consistency

Let me know if you need help determining what content should go in each week's changelog!

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 29, 2025

Merge activity

  • Oct 29, 9:15 PM UTC: NicholasKissel added this pull request to the Graphite merge queue.
  • Oct 29, 9:16 PM UTC: CI is running for this pull request on a draft pull request (#3284) due to your merge queue CI optimization settings.
  • Oct 29, 9:36 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI (Check)).
  • Oct 29, 9:50 PM UTC: NicholasKissel added this pull request to the Graphite merge queue.
  • Oct 29, 9:51 PM UTC: CI is running for this pull request on a draft pull request (#3286) due to your merge queue CI optimization settings.
  • Oct 29, 10:08 PM UTC: CI is running for this pull request on a draft pull request (#3287) due to your merge queue CI optimization settings.
  • Oct 29, 10:28 PM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI (Check)).
  • Nov 5, 6:34 AM UTC: NicholasKissel added this pull request to the Graphite merge queue.
  • Nov 5, 6:34 AM UTC: CI is running for this pull request on a draft pull request (#3373) due to your merge queue CI optimization settings.
  • Nov 5, 6:35 AM UTC: Merged by the Graphite merge queue via draft PR: #3373.

graphite-app bot pushed a commit that referenced this pull request Oct 29, 2025
chore(site): weekly changelog

chore(site): weekly changelog for October 19th
graphite-app bot pushed a commit that referenced this pull request Oct 29, 2025
chore(site): weekly changelog

chore(site): weekly changelog for October 19th
graphite-app bot pushed a commit that referenced this pull request Oct 29, 2025
chore(site): weekly changelog

chore(site): weekly changelog for October 19th
graphite-app bot pushed a commit that referenced this pull request Nov 5, 2025
chore(site): weekly changelog

chore(site): weekly changelog for October 19th
@graphite-app graphite-app bot closed this Nov 5, 2025
@graphite-app graphite-app bot deleted the 10-29-chore_site_weekly_changelog branch November 5, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants