Skip to content

chore(rivetkit): improve conn inspector properties #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore(rivetkit): improve conn inspector properties #3317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion rivetkit-typescript/packages/rivetkit/src/actor/instance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,13 @@ export class ActorInstance<S, CP, CS, V, I, DB extends AnyDatabaseProvider> {
return Array.from(this.#connections.entries()).map(
([id, conn]) => ({
id,
stateEnabled: conn.__stateEnabled,
params: conn.params as any,
state: conn.__stateEnabled ? conn.state : undefined,
status: conn.status,
subscriptions: conn.subscriptions.size,
lastSeen: conn.lastSeen,
stateEnabled: conn.__stateEnabled,
isHibernatable: conn.isHibernatable,
}),
);
},
Expand Down Expand Up @@ -1291,13 +1295,19 @@ export class ActorInstance<S, CP, CS, V, I, DB extends AnyDatabaseProvider> {
#checkConnectionsLiveness() {
this.#rLog.debug({ msg: "checking connections liveness" });

let connected = 0;
let reconnecting = 0;
let removed = 0;
for (const conn of this.#connections.values()) {
if (conn.__status === "connected") {
connected += 1;
this.#rLog.debug({
msg: "connection is alive",
connId: conn.id,
});
} else {
reconnecting += 1;

const lastSeen = conn.__persist.lastSeen;
const sinceLastSeen = Date.now() - lastSeen;
if (
Expand All @@ -1321,9 +1331,18 @@ export class ActorInstance<S, CP, CS, V, I, DB extends AnyDatabaseProvider> {
});

// Assume that the connection is dead here, no need to disconnect anything
removed += 1;
this.#removeConn(conn);
}
}

this.#rLog.debug({
msg: "checked connection liveness",
total: connected + reconnecting,
connected,
reconnecting,
removed,
});
}

/**
Expand Down
Loading