-
Notifications
You must be signed in to change notification settings - Fork 140
feat(rivetkit): configure server port via env (for serverless auto-start) #3640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(rivetkit): configure server port via env (for serverless auto-start) #3640
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Code ReviewThank you for this PR! I've reviewed the changes and found several issues that need to be addressed before merging. Critical Issues1. Missing Error Handling for Invalid Port ValuesLocation: The current implementation uses const defaultPort = getEnvUniversal("RIVET_SERVER_PORT");
if (typeof defaultPort === "undefined") {
return 6420;
}
return parseInt(defaultPort);Problems:
Recommended Fix: 2. Inconsistent Pattern with Other Environment VariablesLooking at similar environment variable handling in the codebase:
Your PR uses Minor Issues3. Missing Test CoverageThere are no tests for this new environment variable functionality. Consider adding tests to verify:
SummaryMust Fix:
Should Consider:
|
More templates
@rivetkit/cloudflare-workers
@rivetkit/db
@rivetkit/framework-base
@rivetkit/next-js
@rivetkit/react
rivetkit
@rivetkit/sql-loader
@rivetkit/engine-runner
@rivetkit/engine-runner-protocol
commit: |

Fixes CLD-37