Skip to content

Conversation

jog1t
Copy link
Collaborator

@jog1t jog1t commented Jul 30, 2025

No description provided.

Copy link

claude bot commented Jul 30, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Copy link
Collaborator Author

jog1t commented Jul 30, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

pkg-pr-new bot commented Jul 30, 2025

Open in StackBlitz

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/actor@1149

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/core@1149

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/db@1149

rivetkit

pnpm add https://pkg.pr.new/rivet-gg/rivetkit@1149

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/cloudflare-workers@1149

@rivetkit/redis

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/redis@1149

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/framework-base@1149

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/react@1149

commit: 093eef4

@jog1t jog1t marked this pull request as ready for review July 30, 2025 10:14
@jog1t jog1t force-pushed the 07-30-chore_example-raw-websocket-handler-proxy_use_correct_url_and_mount_registry branch from 0a9bfea to 093eef4 Compare July 30, 2025 10:56
Copy link

claude bot commented Jul 30, 2025

Claude encountered an error —— View job


I'll analyze this and get back to you.

Comment on lines +6 to 11
const { client, hono } = registry.createServer({
getUpgradeWebSocket: () => upgradeWebSocket,
});

const app = new Hono();
const { injectWebSocket, upgradeWebSocket } = createNodeWebSocket({ app });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a circular dependency in this code. The upgradeWebSocket function is being passed to registry.createServer() before it's actually defined on line 11.

To resolve this issue, please move the registry creation code:

const { client, hono } = registry.createServer({
  getUpgradeWebSocket: () => upgradeWebSocket,
});

to after line 11 where upgradeWebSocket is defined. This will ensure the function exists before it's referenced.

Suggested change
const { client, hono } = registry.createServer({
getUpgradeWebSocket: () => upgradeWebSocket,
});
const app = new Hono();
const { injectWebSocket, upgradeWebSocket } = createNodeWebSocket({ app });
const app = new Hono();
const { injectWebSocket, upgradeWebSocket } = createNodeWebSocket({ app });
const { client, hono } = registry.createServer({
getUpgradeWebSocket: () => upgradeWebSocket,
});

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant