Skip to content

chore(core): fix missing transport for inline tests #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore(core): fix missing transport for inline tests #1287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/rivetkit/src/driver-test-suite/test-inline-client-driver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ export function createTestInlineClientDriver(
headers,
body: actorRequest.body,
signal: actorRequest.signal,
}),
duplex: "half",
} as RequestInit),
);

// Check if it's an error response from our handler
Expand Down Expand Up @@ -560,7 +561,8 @@ async function makeInlineRequest<T>(
method,
args,
} satisfies TestInlineDriverCallRequest),
});
duplex: "half",
} as RequestInit);

if (!response.ok) {
throw new Error(`Failed to call inline ${method}: ${response.statusText}`);
Expand Down
6 changes: 3 additions & 3 deletions packages/rivetkit/src/driver-test-suite/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,14 @@ export async function setupDriverTest(
});
} else if (driverTestConfig.clientType === "inline") {
// Use inline client from driver
const transport = driverTestConfig.transport ?? "websocket";
const managerDriver = createTestInlineClientDriver(
endpoint,
"bare",
driverTestConfig.transport ?? "websocket",
transport,
);
invariant(driverTestConfig.transport, "missing transport");
const runConfig = RunConfigSchema.parse({
transport: driverTestConfig.transport,
transport: transport,
});
client = createClientWithDriver(managerDriver, runConfig);
} else {
Expand Down
Loading