fix: append servers logs when watching #338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hub with
|
| Latest commit: |
1e8185e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://397ef57e.hub-3av.pages.dev |
| Branch Preview URL: | https://09-21-fix-append-servers-log.hub-3av.pages.dev |
This was referenced Sep 21, 2024
Closed
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
jog1t
force-pushed
the
09-21-fix_change_servers_page_wording
branch
from
33d42da
to
6b063d6
Compare
jog1t
force-pushed
the
09-21-fix_append_servers_logs_when_watching
branch
2 times, most recently
from
aedbe74
to
58112c0
Compare
This was referenced Sep 22, 2024
Closed
NathanFlurry
approved these changes
Sep 24, 2024
jog1t
force-pushed
the
09-21-fix_change_servers_page_wording
branch
from
6b063d6
to
f8d6bba
Compare
jog1t
force-pushed
the
09-21-fix_append_servers_logs_when_watching
branch
from
58112c0
to
2a91a3d
Compare
Closed
jog1t
force-pushed
the
09-21-fix_change_servers_page_wording
branch
from
f8d6bba
to
06fab23
Compare
jog1t
force-pushed
the
09-21-fix_append_servers_logs_when_watching
branch
from
2a91a3d
to
794f7e9
Compare
This was referenced Sep 25, 2024
Closed
Closed
jog1t
force-pushed
the
09-21-fix_change_servers_page_wording
branch
from
06fab23
to
aefc822
Compare
jog1t
force-pushed
the
09-21-fix_append_servers_logs_when_watching
branch
from
794f7e9
to
1e8185e
Compare
Merge activity
|
jog1t
added a commit
that referenced
this pull request
Sep 26, 2024
Closes HUB-497 ### TL;DR Enhanced server logs query options with structural sharing for improved performance. ### What changed? - Added `rivetSerialization` import from "@rivet-gg/api/serialization" - Implemented `structuralSharing` function in `serverLogsQueryOptions` - The new function parses old and new data, combining timestamps and lines if both are valid ### How to test? 1. Navigate to the server logs section in the application 2. Observe the logs loading and updating 3. Verify that new log entries are appended correctly without duplicates 4. Check for any performance improvements in log rendering, especially with large datasets ### Why make this change? This change optimizes the handling of server logs by implementing structural sharing. It ensures that new log data is efficiently merged with existing data, reducing unnecessary re-renders and improving overall performance when dealing with large volumes of log entries. This enhancement is particularly beneficial for long-running servers or during intensive debugging sessions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HUB-497
TL;DR
Enhanced server logs query options with structural sharing for improved performance.
What changed?
rivetSerializationimport from "@rivet-gg/api/serialization"structuralSharingfunction inserverLogsQueryOptionsHow to test?
Why make this change?
This change optimizes the handling of server logs by implementing structural sharing. It ensures that new log data is efficiently merged with existing data, reducing unnecessary re-renders and improving overall performance when dealing with large volumes of log entries. This enhancement is particularly beneficial for long-running servers or during intensive debugging sessions.