Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: identify user in Posthog with email and name #74

Merged
merged 1 commit into from
Mar 6, 2024
Merged

feat: identify user in Posthog with email and name #74

merged 1 commit into from
Mar 6, 2024

Conversation

jog1t
Copy link
Contributor

@jog1t jog1t commented Jan 23, 2024

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 23, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2b06251
Status: ✅  Deploy successful!
Preview URL: https://9a9b36dc.hub-3av.pages.dev
Branch Preview URL: https://01-23-posthog-identify-user.hub-3av.pages.dev

View logs

This was referenced Jan 23, 2024
Merged
Merged
@jog1t Graphite App
Copy link
Contributor Author

jog1t commented Jan 23, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jog1t and the rest of your teammates on Graphite Graphite

This was referenced Jan 23, 2024
Closed
Merged
Merged
@jog1t jog1t force-pushed the 01-23-Posthog_identify_user_with_email_and_name branch from 8369d1c to 03a1e47 Compare January 23, 2024 18:37
@jog1t jog1t mentioned this pull request Jan 23, 2024
Merged
@NathanFlurry NathanFlurry changed the base branch from 01-09-Redesign to main January 24, 2024 22:00
@jog1t jog1t marked this pull request as ready for review January 25, 2024 10:23
@jog1t jog1t force-pushed the 01-23-Posthog_identify_user_with_email_and_name branch from 03a1e47 to b0bbbd2 Compare January 25, 2024 10:40
NathanFlurry
NathanFlurry previously requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be interesting to have an idempotent "reidentify user" function that we call in both _refreshTokenInner and/or when the global user updates. There's probably a cleaner way of doing this.

src/utils/global.ts Outdated Show resolved Hide resolved
src/utils/global.ts Outdated Show resolved Hide resolved
@jog1t jog1t force-pushed the 01-23-Posthog_identify_user_with_email_and_name branch 2 times, most recently from 7deea9b to 370896b Compare March 6, 2024 15:07
@jog1t jog1t dismissed NathanFlurry’s stale review March 6, 2024 15:16

not relevant anymore

@jog1t jog1t changed the title Posthog identify user with email and name feat: identify user in Posthog with email and name Mar 6, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Mar 6, 2024 •
edited
Loading

Merge activity

@jog1t jog1t force-pushed the 01-23-Posthog_identify_user_with_email_and_name branch from 370896b to 2b06251 Compare March 6, 2024 15:17
@graphite-app graphite-app bot merged commit 2b06251 into main Mar 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanFlurry NathanFlurry NathanFlurry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jog1t @NathanFlurry