Fix: Seek to entry point by default, if the binary provides one. #5026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rot127
requested review from
wargio,
kazarmy,
thestr4ng3r and
ret2libc
as code owners
Rot127
force-pushed
the
default-entry
branch
3 times, most recently
from
1d06560 to
ca8b4c9
Compare
wargio
reviewed
Mar 23, 2025
wargio
reviewed
Mar 25, 2025
wargio
reviewed
Mar 25, 2025
wargio
approved these changes
Mar 25, 2025
notxvilka
approved these changes
Mar 25, 2025
notxvilka
requested changes
Mar 25, 2025
…provides one. Required by raw firmware images. They don't necessarily define entry0. Besides, not considering the entries provided by the loader is really impolite. As if rizin.c::main knew it better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
RZ_APIfunction and struct this PR changes.RZ_API).Detailed description
Required by raw firmware images. They don't necessarily define
entry0.Besides, not taking the entries provided by the loader as default seek is really impolite.
As if
rizin.c::mainknew it better.Test plan
All green.
Closing issues
...