Skip to content

Commit

Permalink
Linting
Browse files Browse the repository at this point in the history
  • Loading branch information
ThomasRogersDAZN committed Feb 14, 2019
1 parent 9397122 commit f8b9bbb
Show file tree
Hide file tree
Showing 8 changed files with 1,097 additions and 1,069 deletions.
6 changes: 6 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,9 @@ typings/

# next.js build output
.next

# vscode folders
.vscode/

# dstore
.DS_Store
41 changes: 30 additions & 11 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"private": true,
"scripts": {
"install": "lerna bootstrap",
"test:lint": "eslint .",
"test:lint": "eslint .",
"test": "lerna run --concurrency 2 test -- -- --config=../../jest.config.js",
"diff": "lerna diff",
"new-version": "lerna version --conventional-commits --yes"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,52 +1,52 @@
const obfuscater = require('../obfuscate')

const invokeObfuscater = (event, obfuscationFilters = []) => {
return obfuscater(event, obfuscationFilters);
return obfuscater(event, obfuscationFilters)
}

test ('should obfuscate events using the filter', () => {
test('should obfuscate events using the filter', () => {
const event = invokeObfuscater({ test: 'wat' }, ['test'])
expect(event.test).toEqual('******');
expect(event.test).toEqual('******')
})

test ('should obfuscate events with arrays using the filter', () => {
const event = invokeObfuscater({ test: [ { foo: 'wat' }, {foo: 'bar'} ] }, ['test.*.foo'])
expect(event.test[0].foo).toEqual('******');
expect(event.test[1].foo).toEqual('******');
test('should obfuscate events with arrays using the filter', () => {
const event = invokeObfuscater({ test: [ { foo: 'wat' }, { foo: 'bar' } ] }, ['test.*.foo'])
expect(event.test[0].foo).toEqual('******')
expect(event.test[1].foo).toEqual('******')
})

test ('should obfuscate events with multipleArrays arrays using the filter', () => {
const event = invokeObfuscater({ test: [ { foo: { bar: [ {baz: 'heyo' } ] } }, { foo: { bar: [ {baz: 'hey' } ] } } ] }, ["test.*.foo.bar.*.baz"]);
expect(event.test[0].foo.bar[0].baz).toEqual('******');
test('should obfuscate events with multipleArrays arrays using the filter', () => {
const event = invokeObfuscater({ test: [ { foo: { bar: [ { baz: 'heyo' } ] } }, { foo: { bar: [ { baz: 'hey' } ] } } ] }, ['test.*.foo.bar.*.baz'])
expect(event.test[0].foo.bar[0].baz).toEqual('******')
})

test ('should obfuscate every field on an object using the filter', () => {
const event = invokeObfuscater({ test: [ { foo: { bar: [ {baz: { bloop: { blah: "Please Obfuscate Me"} } } ] } }, { foo: { bar: [ {baz: 'hey' } ] } } ] }, ["test.*.foo"]);
expect(event.test[0].foo.bar[0].baz.bloop.blah).toEqual('******');
test('should obfuscate every field on an object using the filter', () => {
const event = invokeObfuscater({ test: [ { foo: { bar: [ { baz: { bloop: { blah: 'Please Obfuscate Me' } } } ] } }, { foo: { bar: [ { baz: 'hey' } ] } } ] }, ['test.*.foo'])
expect(event.test[0].foo.bar[0].baz.bloop.blah).toEqual('******')
})

test ('should not filter fields that dont exist', () => {
const rawEvent = { test: { foo: { bar: { buzz: "Nope" }}}};
const event = invokeObfuscater({ test: { foo: { bar: { buzz: "Nope" }}}}, ["test.foo.bar.boop"])
expect(event).toEqual(rawEvent);
test('should not filter fields that dont exist', () => {
const rawEvent = { test: { foo: { bar: { buzz: 'Nope' } } } }
const event = invokeObfuscater({ test: { foo: { bar: { buzz: 'Nope' } } } }, ['test.foo.bar.boop'])
expect(event).toEqual(rawEvent)
})

test ('should not filter fields that dont exist with arrays', () => {
const event = { test: { foo: { bar: [{ buzz: "Nope" }]}}};
const obfuscatedEvent = invokeObfuscater({ test: { foo: { bar: [{ buzz: "Nope" }]}}}, ["test.foo.bar.*.blap"]);
test('should not filter fields that dont exist with arrays', () => {
const event = { test: { foo: { bar: [{ buzz: 'Nope' }] } } }
const obfuscatedEvent = invokeObfuscater({ test: { foo: { bar: [{ buzz: 'Nope' }] } } }, ['test.foo.bar.*.blap'])

expect(event).toEqual(obfuscatedEvent);
expect(event).toEqual(obfuscatedEvent)
})

test ('should not filter when nothing passed', () => {
const event = { test: { foo: { bar: [{ buzz: "Nope" }]}}};
const obfuscatedEvent = invokeObfuscater({ test: { foo: { bar: [{ buzz: "Nope" }]}}}, []);
test('should not filter when nothing passed', () => {
const event = { test: { foo: { bar: [{ buzz: 'Nope' }] } } }
const obfuscatedEvent = invokeObfuscater({ test: { foo: { bar: [{ buzz: 'Nope' }] } } }, [])

expect(event).toEqual(obfuscatedEvent);
expect(event).toEqual(obfuscatedEvent)
})

test ('should not filter when object doesnt exist', () => {
const event = { test: { foo: { bar: [{ buzz: "Nope" }]}}};
const obfuscatedEvent = invokeObfuscater(event, ["empty"])
expect(event).toEqual(obfuscatedEvent);
})
test('should not filter when object doesnt exist', () => {
const event = { test: { foo: { bar: [{ buzz: 'Nope' }] } } }
const obfuscatedEvent = invokeObfuscater(event, ['empty'])
expect(event).toEqual(obfuscatedEvent)
})
10 changes: 5 additions & 5 deletions packages/lambda-powertools-middleware-obfuscater/index.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
const obfuscateFields = require("./obfuscate");
const obfuscateFields = require('./obfuscate')

// config should be { obfuscationfilters } where obfuscation filters is an array of references
// To the object to filter.
module.exports = ({ obfuscationFilters, filterOnAfter = false }) => ({
after: (handler, next) => {
if (filterOnAfter) {
handler.event = obfuscateFields(handler.event);
handler.event = obfuscateFields(handler.event)
}

next();
next()
},
onError: (handler, next) => {
handler.event = obfuscateFields(handler.event, obfuscationFilters);
next(handler.error);
handler.event = obfuscateFields(handler.event, obfuscationFilters)
next(handler.error)
}
})
Loading

0 comments on commit f8b9bbb

Please sign in to comment.