Skip to content

Simplify SAT equivalence formula #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kellyma2 merged 1 commit into from
Jan 27, 2026
Merged

Simplify SAT equivalence formula #177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions pkg/sat/loader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,15 +164,15 @@ func (loader *Loader) Load(packages []*api.Package, matched, ignoreRegex, allowR

// Generate imply rules
for _, provided := range pkgProvideKeys {
// Create imply rules for every package and add them to the formula
// one provided dependency implies all dependencies from that package
resourceVars := pkgProvides[provided]
bfVar := bf.And(toBFVars(resourceVars)...)
var ands []bf.Formula

// Synchronize all the variables for a given package to the same value.
resourceVars := pkgProvides[provided]
pkgVar := resourceVars[len(resourceVars)-1]
for _, res := range resourceVars {
ands = append(ands, bf.Implies(bf.Var(res.satVarName), bfVar))
ands = append(ands, bf.Eq(bf.Var(pkgVar.satVarName), bf.Var(res.satVarName)))
}
pkgVar := resourceVars[len(resourceVars)-1]

ands = append(ands, bf.Implies(bf.Var(pkgVar.satVarName), loader.explodePackageRequires(pkgVar)))
if conflicts := loader.explodePackageConflicts(pkgVar); conflicts != nil {
ands = append(ands, bf.Implies(bf.Var(pkgVar.satVarName), bf.Not(conflicts)))
Expand Down Expand Up @@ -375,13 +375,6 @@ func (loader *Loader) resolveNewest(pkgName string, archOrder []string) (*Var, e
return newest, nil
}

func toBFVars(vars []*Var) (bfvars []bf.Formula) {
for _, v := range vars {
bfvars = append(bfvars, bf.Var(v.satVarName))
}
return
}

func compareRequires(entry api.Entry, provides []*Var) (accepts []*Var, err error) {
for _, dep := range provides {
entryVer := api.Version{
Expand Down
Loading