Allow model vars to be unused in SAT formula#178
Merged
Conversation
by reworking for loop in the results interpretation code. Previously, the code iterated through SAT model and filtered only `VarTypePackage` vars. The new version iterates through all the vars in our model and filters similar type of vars. The problem was: when a given variable is not used in any constraint, it won't appear in the SAT model. This is not happening yet, as each variable is used, but it's not guaranteed for this assumption to hold in the future. With this change we will be able to correctly identify the excluded packages.
aszady
force-pushed
the
collapse.unused
branch
from
847cabb to
bc5363c
Compare
|
kellyma2
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ A small extract from a larger change #153 ]
Allow model vars to be unused in SAT formula
by reworking for loop in the results interpretation code.
Previously, the code iterated through SAT model and filtered only
VarTypePackagevars. The new version iterates through all the vars in our model and filters similar type of vars.The problem was: when a given variable is not used in any constraint, it won't appear in the SAT model. This is not happening yet, as each variable is used, but it's not guaranteed for this assumption to hold in the future. With this change we will be able to correctly identify the excluded packages.