Add Resource abstraction to the SAT loader#181
Merged
Conversation
aszady
force-pushed
the
collapse.ProvidedResource
branch
from
ed06bc6 to
dbadbb6
Compare
|
aszady
force-pushed
the
collapse.ProvidedResource
branch
2 times, most recently
from
57c8d6d to
b8aefdb
Compare
Collaborator
manuelnaranjo
left a comment
manuelnaranjo
left a comment
There was a problem hiding this comment.
LGTM, but let's wait for @kellyma2
Variable generation is separated into two parts: - extracting `Resource`s provided by the package – data most useful for the `Loader`; - creating SAT variable related to that resource – data most useful for the `Resolve` (`Model`). This modularization of code should facilitates future code changes. The `VarTypeResource` vs. `VarTypeFile` distinction was not used, therefore these were merged for further simplification.
aszady
force-pushed
the
collapse.ProvidedResource
branch
from
b8aefdb to
91cfd90
Compare
kellyma2
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ A small extract from a larger change #153 ]
Variable generation is separated into two parts:
Resources provided by the package – data most useful for theLoader;Resolve(Model).This modularization of code should facilitates future code changes.
The
VarTypeResourcevs.VarTypeFiledistinction was not used, therefore these were merged for further simplification.