Remove dependency on VarContext for collecting sets of pacakges#182
Merged
Conversation
aszady
force-pushed
the
collapse.installSet
branch
from
b700fb9 to
151a020
Compare
|
aszady
force-pushed
the
collapse.installSet
branch
from
151a020 to
23be776
Compare
As the `Resolve` function just divides the input set of `*api.Package` in three different classes (installed, excluded, ignored), there is no need to use `VarContext` as a key in intermediary structs. The refactored logic more clearly implements this intention. Also, this enables removing the `VarContext` in the future.
aszady
force-pushed
the
collapse.installSet
branch
from
23be776 to
2c2cb99
Compare
manuelnaranjo
approved these changes
Jan 28, 2026
Collaborator
manuelnaranjo
left a comment
manuelnaranjo
left a comment
There was a problem hiding this comment.
I don't know why you change the variable name from map to set, but that has no real effect on the change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ A small extract from a larger change #153 ]
As the
Resolvefunction just divides the input set of*api.Packagein three different classes (installed, excluded, ignored), there is no need to useVarContextas a key in intermediary structs.The refactored logic more clearly implements this intention. Also, this enables removing the
VarContextin the future.