Include package architecture in the pinning key #193
Open
aszady wants to merge 3 commits into
Open
Conversation
The pinning logic prevents the discovery of similar packages, effectively freezing the set of involved packages within a given package name to the ones that match requests in the `packages` argument to the `Resolve`. Previously, the pinning mechanism used the package name as its sole key. When a user requested a specific architecture for a package, the resolver was artificially blocked from discovering other architectures of that exact same package. This occurred even when those alternative architectures were mandated by standard dependency relations, effectively breaking the resolution graph for multilib or cross-compiled environments. This change replaces the raw package name with the installation key, which incorporates both the name and the architecture, as the primary domain for pinning. Pinning will still prevent discovering alternative versions (if a particular version was explicitly requested). This also matches more closely the `dnf` behaviour.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pinning logic prevents the discovery of similar packages,
effectively freezing the set of involved packages within a given package name
to the ones that match requests in the
packagesargument to theResolve.Previously, the pinning mechanism used the package name as its sole key.
When a user requested a specific architecture for a package, the resolver was artificially blocked from discovering other architectures of that exact same package.
This occurred even when those alternative architectures were mandated by standard dependency relations, effectively breaking the resolution graph for multilib or cross-compiled environments.
This change replaces the raw package name with the installation key,
which incorporates both the name and the architecture, as the primary domain for pinning.
Pinning will still prevent discovering alternative versions (if a particular version was explicitly requested).
This also matches more closely the
dnfbehaviour.