Make output of bazeldnf more concise upon errors#195
Open
jhorecki-arista wants to merge 1 commit into
Open
Conversation
Changes output of bazeldnf on error from <error message> <bazeldnf help> <error message repeated> to <error message> when error happens in command handler and not during argument parsing.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now when error occurs during the command handling,
the output has the form
for example calling
bazelisk run :bazeldnf fetchwith malformed repo.yaml results in:the repeated error message makes the output of the tool cluttered. Moreover displaying the help here is misleading as for standard cmd tools it usually suggests malformed arguments given to the command. In practice this leads to misattributing problems when looking at the log.
This PR changes this so when error occurs during cmd parsing, help is displayed as expected but for errors originating from cmd handlers, the output is just the error message. In the example above that would be just